content/browser/frame_host/navigator_impl.cc - Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.

Patch Set: Adding setSelfAsOpener parameter. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 22a40a6a09c5178d680c015be596370c98a77b26..6a4618afb1b749ed6142fccb6fee6a969eac1872 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -724,7 +724,6 @@ void NavigatorImpl::RequestOpenURL(

const std::string& extra_headers,

const Referrer& referrer,

WindowOpenDisposition disposition,

- bool force_new_process_for_new_contents,

bool should_replace_current_entry,

bool user_gesture) {

// Note: This can be called for subframes (even when OOPIFs are not possible)

@@ -767,8 +766,6 @@ void NavigatorImpl::RequestOpenURL(

OpenURLParams params(dest_url, referrer, frame_tree_node_id, disposition,

ui::PAGE_TRANSITION_LINK,

true /* is_renderer_initiated */);

- params.force_new_process_for_new_contents =

- force_new_process_for_new_contents;

params.uses_post = uses_post;

params.post_data = body;

params.extra_headers = extra_headers;