Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2921753002: NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.
Patch Set: Fix incognito profile transitions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index b4b4cc124571134c9bd0123f5ef7a716ef6d1192..ceb68ab69162dcd120937f3385c360966d1aa281 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1257,22 +1257,10 @@ void RenderFrameHostImpl::OnOpenURL(const FrameHostMsg_OpenURL_Params& params) {
TRACE_EVENT1("navigation", "RenderFrameHostImpl::OpenURL", "url",
validated_url.possibly_invalid_spec());
- // When |params.disposition| asks OpenURL to create new contents, it always
- // happens because of an explicit user request for new content creation (i.e.
- // opening a link using ctrl-click or middle click). In such cases, the new
- // content should be created in a new renderer to break opener relationship
- // (see https://crbug.com/658386) and to conserve memory per renderer (see
- // https://crbug.com/23815). Note that new content creation that wasn't
- // explicitly requested by the user (i.e. left-clicking a link with
- // target=_blank) goes through a different code path (through
- // WebViewClient::CreateView).
- bool kForceNewProcessForNewContents = true;
-
frame_tree_node_->navigator()->RequestOpenURL(
this, validated_url, params.uses_post, params.resource_request_body,
params.extra_headers, params.referrer, params.disposition,
- kForceNewProcessForNewContents, params.should_replace_current_entry,
- params.user_gesture);
+ params.should_replace_current_entry, params.user_gesture);
}
void RenderFrameHostImpl::OnCancelInitialHistoryLoad() {

Powered by Google App Engine
This is Rietveld 408576698