NOT YET READY: Making chrome.windows.create establish an actual "opener" relationship.

chrome/browser/extensions/api/tabs/tabs_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
@@ skipping 27 matching lines @@
 #include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/common/page_zoom.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_navigation_observer.h"
 #include "extensions/browser/api_test_utils.h"
 #include "extensions/browser/app_window/app_window.h"
 #include "extensions/browser/app_window/app_window_registry.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/test_util.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "extensions/test/result_catcher.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/geometry/rect.h"
@@ skipping 2084 matching lines @@
   browser()->tab_strip_model()->ActivateTabAt(0, true);
   EXPECT_EQ(first_web_contents,
             browser()->tab_strip_model()->GetActiveWebContents());
   browser()->tab_strip_model()->ActivateTabAt(1, true);
   EXPECT_EQ(second_web_contents,
             browser()->tab_strip_model()->GetActiveWebContents());
 
   EXPECT_EQ(url, second_web_contents->GetVisibleURL());
 }
 
-// Window created by chrome.windows.create should be in the same SiteInstance
-// and BrowsingInstance as the opener - this is a regression test for
+// Window created by chrome.windows.create should be in the same
+// BrowsingInstance as the opener - this is a regression test for
 // https://crbug.com/597750.
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowsCreateVsSiteInstance) {
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowsCreateVsBrowsingInstance) {
   const extensions::Extension* extension =
       LoadExtension(test_data_dir_.AppendASCII("../simple_with_file"));
   ASSERT_TRUE(extension);
 
   // Navigate a tab to an extension page.
   GURL extension_url = extension->GetResourceURL("file.html");
   ui_test_utils::NavigateToURL(browser(), extension_url);
   content::WebContents* old_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   // Execute chrome.windows.create and store the new tab in |new_contents|.
   content::WebContents* new_contents = nullptr;
   {
     content::WebContentsAddedObserver observer;
     ASSERT_TRUE(content::ExecuteScript(old_contents,
                                        "window.name = 'old-contents';\n"
                                        "chrome.windows.create({url: '" +
                                            extension_url.spec() + "'})"));
     new_contents = observer.GetWebContents();
     ASSERT_TRUE(content::WaitForLoadStop(new_contents));
   }
 
+  // Navigate the old and the new tab to a web URL.
+  ASSERT_TRUE(StartEmbeddedTestServer());
+  GURL web_url1 = embedded_test_server()->GetURL("/title1.html");
+  GURL web_url2 = embedded_test_server()->GetURL("/title2.html");
+  {
+    content::TestNavigationObserver nav_observer(new_contents, 1);
+    ASSERT_TRUE(content::ExecuteScript(
+        new_contents, "window.location = '" + web_url1.spec() + "';"));
+    nav_observer.Wait();
+  }
+  {
+    content::TestNavigationObserver nav_observer(old_contents, 1);
+    ASSERT_TRUE(content::ExecuteScript(
+        old_contents, "window.location = '" + web_url2.spec() + "';"));
+    nav_observer.Wait();
+  }
+  EXPECT_EQ(web_url1, new_contents->GetMainFrame()->GetLastCommittedURL());
+  EXPECT_EQ(web_url2, old_contents->GetMainFrame()->GetLastCommittedURL());
+
   // Verify that the old and new tab are in the same process and SiteInstance.

[Charlie Reis, 2017/06/05 21:06:28]

nit: Remove "and SiteInstance" if we aren't checking that.

[Łukasz Anforowicz, 2017/06/05 22:06:54]

Done.

-  // Note: both test assertions are important - one observed failure mode was
-  // having the same process, but different SiteInstance.
   EXPECT_EQ(old_contents->GetMainFrame()->GetProcess(),
             new_contents->GetMainFrame()->GetProcess());
-  EXPECT_EQ(old_contents->GetMainFrame()->GetSiteInstance(),
-            new_contents->GetMainFrame()->GetSiteInstance());
 
-  // Verify that the |new_contents| doesn't have a |window.opener| set.
-  bool window_opener_cast_to_bool = true;
-  EXPECT_TRUE(ExecuteScriptAndExtractBool(
-      new_contents, "window.domAutomationController.send(!!window.opener)",
-      &window_opener_cast_to_bool));
-  EXPECT_FALSE(window_opener_cast_to_bool);
+  // Verify the old and new contents are in the same browsing instance.

[Charlie Reis, 2017/06/05 21:06:28]

nit: BrowsingInstance

[Łukasz Anforowicz, 2017/06/05 22:06:54]

Done.

+  EXPECT_TRUE(
+      old_contents->GetMainFrame()->GetSiteInstance()->IsRelatedSiteInstance(
+          new_contents->GetMainFrame()->GetSiteInstance()));
+
+  // Verify that the |new_contents| has |window.opener| set.
+  std::string location_of_opener;
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      new_contents,
+      "window.domAutomationController.send(window.opener.location.href)",
+      &location_of_opener));
+  EXPECT_EQ(old_contents->GetMainFrame()->GetLastCommittedURL().spec(),
+            location_of_opener);
 
   // Verify that |new_contents| can find |old_contents| using window.open/name.
   std::string location_of_other_window;
   EXPECT_TRUE(ExecuteScriptAndExtractString(
       new_contents,
       "var w = window.open('', 'old-contents');\n"
       "window.domAutomationController.send(w.location.href);",
       &location_of_other_window));
   EXPECT_EQ(old_contents->GetMainFrame()->GetLastCommittedURL().spec(),
             location_of_other_window);
 }
 
 }  // namespace extensions