Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/app/chrome_exe_main_mac.cc

Issue 2921733002: Add flags for v2 sandbox to Chrome and Helper executable. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/sandbox_init_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_exe_main_mac.cc
diff --git a/chrome/app/chrome_exe_main_mac.cc b/chrome/app/chrome_exe_main_mac.cc
index f446f445864a359ec57e120b5163082fd180c878..c420b3d49a3cf9276215948218a4e0ea8611becd 100644
--- a/chrome/app/chrome_exe_main_mac.cc
+++ b/chrome/app/chrome_exe_main_mac.cc
@@ -32,6 +32,11 @@ typedef int (*ChromeMainPtr)(int, char**);
#if defined(HELPER_EXECUTABLE)
// The command line parameter to engage the v2 sandbox.
constexpr char v2_sandbox_arg[] = "--v2-sandbox";
+// The command line paramter indicating that the v2 sandbox is enabled. This
+// must be different than the "v2-sandbox" flag to avoid endless re-executing.
+// The flag tells the sandbox initialization code inside Chrome that the sandbox
+// should already be enabled.
+char v2_sandbox_enabled_arg[] = "--v2-sandbox-enabled";
Robert Sesek 2017/06/01 22:07:49 constexpr?
Robert Sesek 2017/06/01 22:07:49 Since "enabled" is so overloaded for features, I t
Greg K 2017/06/01 22:10:40 The reason I make it a positive for now is because
Robert Sesek 2017/06/01 22:12:28 That's true, unless you propagated the --v2-sandbo
Greg K 2017/06/01 22:13:22 Yes. I don't want to re-add the new flag because i
Greg K 2017/06/01 22:23:56 I don't actually know a better way to do this. The
Greg K 2017/06/01 22:26:11 For what it's worth, these are document as constan
// The command line parameter for the file descriptor used to receive the
// sandbox policy.
constexpr char fd_mapping_arg[] = "--fd_mapping=";
@@ -71,6 +76,8 @@ __attribute__((noreturn)) void SandboxExec(const char* exec_path,
new_argv.push_back(argv[i]);
}
}
+ // Tell Chrome that the sandbox should already be enabled.
+ new_argv.push_back(v2_sandbox_enabled_arg);
new_argv.push_back(nullptr);
// The helper executable re-executes itself under the sandbox.
« no previous file with comments | « no previous file | content/common/sandbox_init_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698