Harden a few builtins

Harden a few builtins

Introducing BUILTIN_ASSERT, builtins' equivalent of RUNTIME_ASSERT.

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21439

[Jakob Kummerow, 2014-05-21 11:15:17]

PTAL.

[rossberg, 2014-05-21 14:30:15]

LGTM with qualms -- IMO, instead of starting to turn random functions into
macros just for the sake of visibility, the more scalable and more robust
approach would be to change the JS code such that by default, a function does
not end up in the builtin object, i.e., by putting everything into a block. Then
only selected functions would be -- explicitly -- "exported" to a global
variable, and others are kept local by construction. (Notably, that would make
addressing both the troubling functions in this CL moot.)

https://codereview.chromium.org/292173011/diff/20001/src/uri.js
File src/uri.js (right):

https://codereview.chromium.org/292173011/diff/20001/src/uri.js#newcode89
src/uri.js:89: macro URI_DECODE_OCTETS(OCTETS, RESULT, INDEX)
Let's at least add a comment that explains why this was done, and a TODO with
the plan to replace it with a scalable solution.

[Jakob Kummerow, 2014-05-22 12:33:58]

OK, how do you like this approach instead?

[rossberg, 2014-05-22 13:23:05]

Like that much better. :) LGTM

https://codereview.chromium.org/292173011/diff/40001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/292173011/diff/40001/src/promise.js#newcode22
src/promise.js:22: var promiseStatus = GLOBAL_PRIVATE("Promise#status");
Can't these go into the closure as well?

[Jakob Kummerow, 2014-05-22 13:54:58]

https://codereview.chromium.org/292173011/diff/40001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/292173011/diff/40001/src/promise.js#newcode22
src/promise.js:22: var promiseStatus = GLOBAL_PRIVATE("Promise#status");
On 2014/05/22 13:23:05, rossberg wrote:
> Can't these go into the closure as well?

Unfortunately no, because debugger. Added a TODO.

[Jakob Kummerow, 2014-05-22 13:59:46]

Committed patchset #5 manually as r21439 (presubmit successful).