Source/core/animation/CompositorAnimations.cpp - Issue 292173009: Web Animations - responsive interpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimations.cpp

Issue 292173009: Web Animations - responsive interpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@0519_MySeparation

Patch Set: applyAndSnapshotAnimatableValue Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/web-animations-api/animations-responsive-transform.html ('k') | Source/core/animation/InterpolableValue.h » ('j') | Source/core/animation/StringKeyframe.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/CompositorAnimations.cpp

diff --git a/Source/core/animation/CompositorAnimations.cpp b/Source/core/animation/CompositorAnimations.cpp

index 6d71fc85a7f9d3d79685944daa15ab5a3fd0ec86..f2128db3b61fe273d69f89534086cdbc33a6ad16 100644

--- a/Source/core/animation/CompositorAnimations.cpp

+++ b/Source/core/animation/CompositorAnimations.cpp

@@ -143,7 +143,8 @@ bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& tim

ASSERT(frames.size() >= 2);

for (size_t i = 0; i < frames.size(); ++i) {

const Keyframe::PropertySpecificKeyframe *frame = frames[i].get();

- if (frame->composite() != AnimationEffect::CompositeReplace)

+ // FIXME: Determine candidacy based on the CSSValue instead of a snapshot AnimatableValue.

+ if (frame->composite() != AnimationEffect::CompositeReplace || !frame->getAnimatableValue())

return false;

switch (*it) {