Web Animations - responsive interpolation

Source/core/animation/StringKeyframe.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef StringKeyframe_h
 #define StringKeyframe_h
 
 #include "core/animation/Keyframe.h"
 #include "core/css/StylePropertySet.h"
 
@@ skipping 18 matching lines @@
     virtual PropertySet properties() const OVERRIDE;
 
     virtual void trace(Visitor*) OVERRIDE;
 
     class PropertySpecificKeyframe : public Keyframe::PropertySpecificKeyframe {
     public:
         PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, CSSValue*, AnimationEffect::CompositeOperation);
 
         CSSValue* value() const { return m_value.get(); }
         virtual const PassRefPtrWillBeRawPtr<AnimatableValue> getAnimatableValue() const OVERRIDE FINAL {
-            ASSERT(m_animatableValueCache);

[shans, 2014/05/26 03:31:01]

Why did we remove this assert?

[alancutter (OOO until 2018), 2014/05/26 05:22:41]

This may return nullptr for transform/opacity now if style dependent values are
used in the keyframe, see the change in CompositorAnimations.cpp.
The sooner we kill this function the better.

[Eric Willigers, 2014/05/26 06:32:47]

With deferred style resolving, the keyframe's cached value can be null.

CompositorAnimations::isCandidateForAnimationOnCompositor now explicitly checks
for null.

             return m_animatableValueCache.get();
         }
 
         virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> neutralKeyframe(double offset, PassRefPtr<TimingFunction> easing) const OVERRIDE FINAL;
         virtual PassRefPtrWillBeRawPtr<Interpolation> createInterpolation(CSSPropertyID, WebCore::Keyframe::PropertySpecificKeyframe* end, Element*) const OVERRIDE FINAL;
 
         virtual void trace(Visitor*) OVERRIDE;
 
     private:
         PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, CSSValue*);
@@ skipping 21 matching lines @@
 };
 
 typedef StringKeyframe::PropertySpecificKeyframe StringPropertySpecificKeyframe;
 
 DEFINE_TYPE_CASTS(StringKeyframe, Keyframe, value, value->isStringKeyframe(), value.isStringKeyframe());
 DEFINE_TYPE_CASTS(StringPropertySpecificKeyframe, Keyframe::PropertySpecificKeyframe, value, value->isStringPropertySpecificKeyframe(), value.isStringPropertySpecificKeyframe());
 
 }
 
 #endif