Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 292173006: Rudimentary keyboard navigation support for <video>/<audio> (Closed)

Created:
6 years, 7 months ago by fs
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Visibility:
Public.

Description

Rudimentary keyboard navigation support for <video>/<audio> Remove the override of hasCustomFocusLogic() for HTMLMediaElement. This allows focus navigation (<tab>ing) to reach the controls. BUG=135661 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
fs
Starting change to get some form of keyboard navigation going. The "auto-hide" functionality is still ...
6 years, 7 months ago (2014-05-20 17:04:38 UTC) #1
philipj_slow
Have you tracked down the history of why hasCustomFocusLogic() was there in the first place?
6 years, 7 months ago (2014-05-21 08:48:30 UTC) #2
fs
On 2014/05/21 08:48:30, philipj wrote: > Have you tracked down the history of why hasCustomFocusLogic() ...
6 years, 7 months ago (2014-05-21 12:04:57 UTC) #3
philipj_slow
OK, another todo that was never done :) My only concern here is that without ...
6 years, 7 months ago (2014-05-21 13:50:01 UTC) #4
fs
On 2014/05/21 13:50:01, philipj wrote: > OK, another todo that was never done :) My ...
6 years, 7 months ago (2014-05-21 13:58:10 UTC) #5
philipj_slow
I haven't compiled and tested this patch, I'm just guessing that the controls will fade ...
6 years, 7 months ago (2014-05-21 14:28:02 UTC) #6
fs
On 2014/05/21 14:28:02, philipj wrote: > I haven't compiled and tested this patch, I'm just ...
6 years, 7 months ago (2014-05-21 15:07:53 UTC) #7
philipj_slow
On 2014/05/21 15:07:53, fs wrote: > I uploaded the tentative heuristic to https://codereview.chromium.org/297783004 > in ...
6 years, 7 months ago (2014-05-21 22:11:25 UTC) #8
acolwell GONE FROM CHROMIUM
lgtm
6 years, 7 months ago (2014-05-22 00:21:36 UTC) #9
fs
The CQ bit was checked by fs@opera.com
6 years, 7 months ago (2014-05-26 07:36:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/292173006/1
6 years, 7 months ago (2014-05-26 07:36:39 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 09:04:16 UTC) #12
Message was sent while issue was closed.
Change committed as 174795

Powered by Google App Engine
This is Rietveld 408576698