Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2921683002: Normalize URIs on entry to ValidatingInstrumentation. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Normalize URIs on entry to ValidatingInstrumentation. This makes it possible to remove a type inferrer hack that wouldn't have worked properly with part files. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/eec5e74188fc7b437c406286c91e4a712e55bf20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +1 line, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-01 15:46:21 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-01 15:48:20 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-01 16:55:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eec5e74188fc7b437c406286c91e4a712e55bf20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698