Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2921673003: Make ClosureTask only accept Element-level APIs instead of resolvedAst. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make ClosureTask only accept Element-level APIs instead of resolvedAst. BAAAAABY STEPS here. BUG= R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b7661431bf840b8cad5fe45922997ce163a63322

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +12 lines, -15 lines 2 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Emily Fortuna
This CL is so incremental I forgot how to count that low.
3 years, 6 months ago (2017-06-02 01:25:53 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2921673003/diff/40001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2921673003/diff/40001/pkg/compiler/lib/src/closure.dart#newcode53 pkg/compiler/lib/src/closure.dart:53: return measure(() { I suspect that you need ...
3 years, 6 months ago (2017-06-02 16:39:27 UTC) #5
Siggi Cherem (dart-lang)
lgtm too
3 years, 6 months ago (2017-06-02 17:30:01 UTC) #6
Emily Fortuna
https://codereview.chromium.org/2921673003/diff/40001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2921673003/diff/40001/pkg/compiler/lib/src/closure.dart#newcode53 pkg/compiler/lib/src/closure.dart:53: return measure(() { On 2017/06/02 16:39:27, Johnni Winther wrote: ...
3 years, 6 months ago (2017-06-05 17:33:59 UTC) #7
Emily Fortuna
3 years, 6 months ago (2017-06-05 17:34:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
b7661431bf840b8cad5fe45922997ce163a63322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698