Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2921663002: Revert "Add groupBy to Stream." (Closed)

Created:
3 years, 6 months ago by floitsch
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add groupBy to Stream." This reverts commit 3e8bfb1adbf7ee156644ed0d4327f410c91a6564 and 3f90b06836fca56e72cfadbc7d61590cec79e71c. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/33f360cc38c23d82ee0c02a9792466062f3225cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -425 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/async/stream.dart View 2 chunks +0 lines, -103 lines 0 comments Download
D tests/lib/async/stream_group_by_test.dart View 1 chunk +0 lines, -319 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
3 years, 6 months ago (2017-06-01 14:06:47 UTC) #2
Lasse Reichstein Nielsen
LGTM
3 years, 6 months ago (2017-06-01 14:10:32 UTC) #3
floitsch
3 years, 6 months ago (2017-06-01 14:11:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
33f360cc38c23d82ee0c02a9792466062f3225cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698