Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2921653003: M60: MD Settings: URL encode text queries before adding them to the URL. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{about: boolean, settings: boolean}} 6 * @typedef {{about: boolean, settings: boolean}}
7 */ 7 */
8 var MainPageVisibility; 8 var MainPageVisibility;
9 9
10 /** 10 /**
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 if (result.canceled) { 263 if (result.canceled) {
264 // Nothing to do here. A previous search request was canceled 264 // Nothing to do here. A previous search request was canceled
265 // because a new search request was issued with a different query 265 // because a new search request was issued with a different query
266 // before the previous completed. 266 // before the previous completed.
267 return; 267 return;
268 } 268 }
269 269
270 this.toolbarSpinnerActive = false; 270 this.toolbarSpinnerActive = false;
271 this.inSearchMode_ = !result.wasClearSearch; 271 this.inSearchMode_ = !result.wasClearSearch;
272 this.showNoResultsFound_ = 272 this.showNoResultsFound_ =
273 this.inSearchMode_ && result.didFindMatches; 273 this.inSearchMode_ && !result.didFindMatches;
274 274
275 if (this.inSearchMode_) { 275 if (this.inSearchMode_) {
276 Polymer.IronA11yAnnouncer.requestAvailability(); 276 Polymer.IronA11yAnnouncer.requestAvailability();
277 this.fire('iron-announce', { 277 this.fire('iron-announce', {
278 text: this.showNoResultsFound_ ? 278 text: this.showNoResultsFound_ ?
279 loadTimeData.getString('searchNoResults') : 279 loadTimeData.getString('searchNoResults') :
280 loadTimeData.getStringF('searchResults', query) 280 loadTimeData.getStringF('searchResults', query)
281 }); 281 });
282 } 282 }
283 }.bind(this)); 283 }.bind(this));
284 }.bind(this), 0); 284 }.bind(this), 0);
285 }.bind(this)); 285 }.bind(this));
286 }, 286 },
287 }); 287 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698