chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java - Issue 2921623004: Support badge icon in WebAPK update components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

Issue 2921623004: Support badge icon in WebAPK update components (Closed)

Patch Set: Support badge icon in WebAPK update components Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

index 06b707300b098fe36b61078aefa09b31c4ebf70e..e0ff61f312efee5d7297a243ea054ca506cb36ba 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

@@ -80,11 +80,12 @@ public class WebApkUpdateDataFetcherTest {

}

@Override

- public void onGotManifestData(WebApkInfo fetchedInfo, String bestIconUrl) {

+ public void onGotManifestData(

+ WebApkInfo fetchedInfo, String primaryIconUrl, String badgeIconUrl) {

Assert.assertNull(mName);

mWebApkCompatible = true;

mName = fetchedInfo.name();

- mBestIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap().get(bestIconUrl);

+ mBestIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap().get(primaryIconUrl);

pkotwicz 2017/06/07 21:22:23 Should |mBestIconMurmur2Hash| be renamed to |mPrim

F 2017/06/08 20:01:12 Done.

notifyCalled();

}