Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.h

Issue 2921623004: Support badge icon in WebAPK update components (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.h
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.h b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
index 2f1db42aa7588ed391b4d4bbea17e7f00aa8cffb..7f341f18e04a8ce1fb3ea167611250b1a2bd2ec3 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.h
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.h
@@ -60,12 +60,12 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
// Called once the installable data has been fetched.
void OnDidGetInstallableData(const InstallableData& installable_data);
- // Called with the computed Murmur2 hash for the app icon.
- void OnGotIconMurmur2Hash(const std::string& best_primary_icon_murmur2_hash);
+ // Called with the computed Murmur2 hash for the primary icon.
+ void OnGotPrimaryIconMurmur2Hash(const std::string& primary_icon_hash);
- void OnDataAvailable(const ShortcutInfo& info,
- const std::string& best_primary_icon_murmur2_hash,
- const SkBitmap& best_primary_icon);
+ void OnDataAvailable(const std::string& primary_icon_murmur2_hash,
+ bool did_fetch_badge_icon,
+ const std::string& badge_icon_murmur2_hash);
// Called when a page has no Web Manifest or the Web Manifest is not WebAPK
// compatible.
@@ -88,7 +88,8 @@ class WebApkUpdateDataFetcher : public content::WebContentsObserver {
// Downloaded data for |web_manifest_url_|.
ShortcutInfo info_;
- SkBitmap best_primary_icon_;
+ SkBitmap primary_icon_;
+ SkBitmap badge_icon_;
base::WeakPtrFactory<WebApkUpdateDataFetcher> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698