Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java

Issue 2921623004: Support badge icon in WebAPK update components (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
index 06b707300b098fe36b61078aefa09b31c4ebf70e..04f66495fa435e0e7c9e6538d53d5842de12ee4e 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateDataFetcherTest.java
@@ -71,7 +71,7 @@ public class WebApkUpdateDataFetcherTest {
extends CallbackHelper implements WebApkUpdateDataFetcher.Observer {
private boolean mWebApkCompatible;
private String mName;
- private String mBestIconMurmur2Hash;
+ private String mPrimaryIconMurmur2Hash;
@Override
public void onWebManifestForInitialUrlNotWebApkCompatible() {
@@ -80,11 +80,12 @@ public class WebApkUpdateDataFetcherTest {
}
@Override
- public void onGotManifestData(WebApkInfo fetchedInfo, String bestIconUrl) {
+ public void onGotManifestData(
+ WebApkInfo fetchedInfo, String primaryIconUrl, String badgeIconUrl) {
Assert.assertNull(mName);
mWebApkCompatible = true;
mName = fetchedInfo.name();
- mBestIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap().get(bestIconUrl);
+ mPrimaryIconMurmur2Hash = fetchedInfo.iconUrlToMurmur2HashMap().get(primaryIconUrl);
notifyCalled();
}
@@ -96,8 +97,8 @@ public class WebApkUpdateDataFetcherTest {
return mName;
}
- public String bestIconMurmur2Hash() {
- return mBestIconMurmur2Hash;
+ public String primaryIconMurmur2Hash() {
+ return mPrimaryIconMurmur2Hash;
}
}
@@ -208,6 +209,6 @@ public class WebApkUpdateDataFetcherTest {
mTestServer.getURL(WEB_MANIFEST_WITH_LONG_ICON_MURMUR2_HASH), waiter);
waiter.waitForCallback(0);
- Assert.assertEquals(LONG_ICON_MURMUR2_HASH, waiter.bestIconMurmur2Hash());
+ Assert.assertEquals(LONG_ICON_MURMUR2_HASH, waiter.primaryIconMurmur2Hash());
}
}

Powered by Google App Engine
This is Rietveld 408576698