Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2921583002: Fix a corner case of function type inference. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a corner case of function type inference. When an expression function's expression has type `dynamic` (or `Null`, since `Null` is coerced to `dynamic`), the inferred return type is taken from the context. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7cdf85da064386dbdf8d5262f4345c7f3bb68559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 2 chunks +0 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart.strong.expect View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-01 04:18:02 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-01 04:20:52 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-01 04:26:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7cdf85da064386dbdf8d5262f4345c7f3bb68559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698