Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2921533004: Annotate optional parameter inferred types in front end test cases. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Annotate optional parameter inferred types in front end test cases. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d17f3f3bbdb733894bb4f4425501a4f14bcf9b5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_initializing_formal_default_formal.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-01 23:23:15 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-02 03:24:06 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-02 03:45:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d17f3f3bbdb733894bb4f4425501a4f14bcf9b5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698