Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4636)

Unified Diff: chrome/browser/ui/views/toolbar/back_button.h

Issue 292153008: linux_aura: Fix the insets on LabelButtons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved to a chain of CreateDefaultBorder()s instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/back_button.h
diff --git a/chrome/browser/ui/views/toolbar/back_button.h b/chrome/browser/ui/views/toolbar/back_button.h
index 3225706ad1b4a634b6dcb6439072ec58371285d0..516dd52a709d8691c222fc22fe37a140056bb3e0 100644
--- a/chrome/browser/ui/views/toolbar/back_button.h
+++ b/chrome/browser/ui/views/toolbar/back_button.h
@@ -31,7 +31,8 @@ class BackButton : public ToolbarButton {
protected:
virtual gfx::Rect GetThemePaintRect() const OVERRIDE;
- virtual scoped_ptr<views::Border> CreateDefaultBorder() const OVERRIDE;
+ virtual scoped_ptr<views::LabelButtonBorder> CreateDefaultBorder() const
+ OVERRIDE;
msw 2014/05/22 18:09:22 why did this change back to putting OVERRIDE on it
Elliot Glaysher 2014/05/22 18:14:03 Because this is what clang-format does. (Likewise,
sky 2014/05/22 19:44:21 The style guide previously said don't do this (sam
private:
// Any leading margin to be applied. Used when the back button is in

Powered by Google App Engine
This is Rietveld 408576698