Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Issue 292153008: linux_aura: Fix the insets on LabelButtons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved to a chain of CreateDefaultBorder()s instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/libgtk2ui/gtk2_ui.cc
diff --git a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
index 58ad3aa3b5521cf04063896a21b5937ab7ec5df3..bb92ddae9cc074a1836ce9ce8d7e2f05ee8113d1 100644
--- a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
+++ b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
@@ -559,7 +559,8 @@ scoped_ptr<views::Border> Gtk2UI::CreateNativeBorder(
if (owning_button->GetNativeTheme() != NativeThemeGtk2::instance())
return border.Pass();
- return scoped_ptr<views::Border>(new Gtk2Border(this, owning_button));
+ return scoped_ptr<views::Border>(
+ new Gtk2Border(this, owning_button, border.Pass()));
}
void Gtk2UI::AddWindowButtonOrderObserver(
@@ -940,9 +941,6 @@ void Gtk2UI::LoadGtkValues() {
GdkColorToSkColor(entry_style->base[GTK_STATE_ACTIVE]);
inactive_selection_fg_color_ =
GdkColorToSkColor(entry_style->text[GTK_STATE_ACTIVE]);
-
- // Update the insets that we hand to Gtk2Border.
- UpdateButtonInsets();
}
GdkColor Gtk2UI::BuildFrameColors(GtkStyle* frame_style) {
@@ -1359,34 +1357,6 @@ SkBitmap Gtk2UI::DrawGtkButtonBorder(int gtk_state,
return border;
}
-gfx::Insets Gtk2UI::GetButtonInsets() const {
- return button_insets_;
-}
-
-void Gtk2UI::UpdateButtonInsets() {
- GtkWidget* window = gtk_offscreen_window_new();
- GtkWidget* button = gtk_button_new();
- gtk_container_add(GTK_CONTAINER(window), button);
-
- GtkBorder* border = NULL;
- gtk_widget_style_get(GTK_WIDGET(button),
- "default-border",
- &border,
- NULL);
-
- gfx::Insets insets;
- if (border) {
- button_insets_ = gfx::Insets(border->top, border->left,
- border->bottom, border->right);
- gtk_border_free(border);
- } else {
- // Defined in gtkbutton.c:
- button_insets_ = gfx::Insets(1, 1, 1, 1);
- }
-
- gtk_widget_destroy(window);
-}
-
void Gtk2UI::ClearAllThemeData() {
gtk_images_.clear();
}

Powered by Google App Engine
This is Rietveld 408576698