Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: build/common.gypi

Issue 292153006: Enable mac_strip_release under ASan on OSX. Remove the .saves files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added a comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1988 matching lines...) Expand 10 before | Expand all | Expand 10 after
1999 'clang_chrome_plugins_flags': [ 1999 'clang_chrome_plugins_flags': [
2000 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' 2000 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
2001 ], 2001 ],
2002 }], 2002 }],
2003 2003
2004 ['asan==1', { 2004 ['asan==1', {
2005 'clang%': 1, 2005 'clang%': 1,
2006 'use_allocator%': 'none', 2006 'use_allocator%': 'none',
2007 }], 2007 }],
2008 ['asan==1 and OS=="mac"', { 2008 ['asan==1 and OS=="mac"', {
2009 # TODO(glider): we do not strip ASan binaries until the dynamic ASan 2009 # Strip and produce the .dSYM files.
2010 # runtime is fully adopted. See http://crbug.com/242503. 2010 'mac_strip_release': 1,
2011 'mac_strip_release': 0,
2012 }], 2011 }],
2013 ['lsan==1', { 2012 ['lsan==1', {
2014 'clang%': 1, 2013 'clang%': 1,
2015 }], 2014 }],
2016 ['tsan==1', { 2015 ['tsan==1', {
2017 'clang%': 1, 2016 'clang%': 1,
2018 'use_custom_libcxx%': 1, 2017 'use_custom_libcxx%': 1,
2019 }], 2018 }],
2020 ['msan==1', { 2019 ['msan==1', {
2021 'clang%': 1, 2020 'clang%': 1,
(...skipping 2647 matching lines...) Expand 10 before | Expand all | Expand 10 after
4669 }], 4668 }],
4670 ], 4669 ],
4671 }, 4670 },
4672 'postbuild_name': 'Change Mach-O Flags', 4671 'postbuild_name': 'Change Mach-O Flags',
4673 'action': [ 4672 'action': [
4674 '<(change_mach_o_flags_path)', 4673 '<(change_mach_o_flags_path)',
4675 '>@(change_mach_o_flags_options)', 4674 '>@(change_mach_o_flags_options)',
4676 ], 4675 ],
4677 }, 4676 },
4678 ], 4677 ],
4679 'conditions': [
4680 ['asan==1', {
4681 'variables': {
4682 'asan_saves_file': 'asan.saves',
4683 },
4684 'xcode_settings': {
4685 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
4686 },
4687 }],
4688 ],
4689 'target_conditions': [ 4678 'target_conditions': [
4690 ['mac_pie==1 and release_valgrind_build==0', { 4679 ['mac_pie==1 and release_valgrind_build==0', {
4691 # Turn on position-independence (ASLR) for executables. When 4680 # Turn on position-independence (ASLR) for executables. When
4692 # PIE is on for the Chrome executables, the framework will 4681 # PIE is on for the Chrome executables, the framework will
4693 # also be subject to ASLR. 4682 # also be subject to ASLR.
4694 # Don't do this when building for Valgrind, because Valgrind 4683 # Don't do this when building for Valgrind, because Valgrind
4695 # doesn't understand slide. TODO: Make Valgrind on Mac OS X 4684 # doesn't understand slide. TODO: Make Valgrind on Mac OS X
4696 # understand slide, and get rid of the Valgrind check. 4685 # understand slide, and get rid of the Valgrind check.
4697 'xcode_settings': { 4686 'xcode_settings': {
4698 'OTHER_LDFLAGS': [ 4687 'OTHER_LDFLAGS': [
(...skipping 19 matching lines...) Expand all
4718 'STRIP_INSTALLED_PRODUCT': 'YES', 4707 'STRIP_INSTALLED_PRODUCT': 'YES',
4719 'target_conditions': [ 4708 'target_conditions': [
4720 ['_type=="shared_library" or _type=="loadable_module"', { 4709 ['_type=="shared_library" or _type=="loadable_module"', {
4721 # The Xcode default is to strip debugging symbols 4710 # The Xcode default is to strip debugging symbols
4722 # only (-S). Local symbols should be stripped as 4711 # only (-S). Local symbols should be stripped as
4723 # well, which will be handled by -x. Xcode will 4712 # well, which will be handled by -x. Xcode will
4724 # continue to insert -S when stripping even when 4713 # continue to insert -S when stripping even when
4725 # additional flags are added with STRIPFLAGS. 4714 # additional flags are added with STRIPFLAGS.
4726 'STRIPFLAGS': '-x', 4715 'STRIPFLAGS': '-x',
4727 }], # _type=="shared_library" or _type=="loadable_modul e" 4716 }], # _type=="shared_library" or _type=="loadable_modul e"
4728 ['_type=="executable"', {
4729 'conditions': [
4730 ['asan==1', {
4731 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
4732 }]
4733 ],
4734 }], # _type=="executable" and asan==1
4735 ], # target_conditions 4717 ], # target_conditions
4736 }, # xcode_settings 4718 }, # xcode_settings
4737 }, # configuration "Release" 4719 }, # configuration "Release"
4738 }, # configurations 4720 }, # configurations
4739 }, { # mac_real_dsym != 1 4721 }, { # mac_real_dsym != 1
4740 # To get a fast fake .dSYM bundle, use a post-build step to 4722 # To get a fast fake .dSYM bundle, use a post-build step to
4741 # produce the .dSYM and strip the executable. strip_from_xcode 4723 # produce the .dSYM and strip the executable. strip_from_xcode
4742 # only operates in the Release configuration. 4724 # only operates in the Release configuration.
4743 'postbuilds': [ 4725 'postbuilds': [
4744 { 4726 {
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
5365 # settings in target dicts. SYMROOT is a special case, because many other 5347 # settings in target dicts. SYMROOT is a special case, because many other
5366 # Xcode variables depend on it, including variables such as 5348 # Xcode variables depend on it, including variables such as
5367 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5349 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5368 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5350 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5369 # files to appear (when present) in the UI as actual files and not red 5351 # files to appear (when present) in the UI as actual files and not red
5370 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5352 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5371 # and therefore SYMROOT, needs to be set at the project level. 5353 # and therefore SYMROOT, needs to be set at the project level.
5372 'SYMROOT': '<(DEPTH)/xcodebuild', 5354 'SYMROOT': '<(DEPTH)/xcodebuild',
5373 }, 5355 },
5374 } 5356 }
OLDNEW
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698