Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_unpositioned_float.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp b/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
index 092f10e09973cac69a5c9c40b38647f633b49cdf..fa27a766874e2d4038e263350e174e8e02ff61c4 100644
--- a/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
+++ b/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
@@ -49,14 +49,14 @@ TEST_F(NGInlineLayoutTest, BlockWithSingleTextNode) {
ToLayoutNGBlockFlow(target->GetLayoutObject());
RefPtr<NGConstraintSpace> constraint_space =
ConstraintSpaceForElement(block_flow);
- NGBlockNode* node = new NGBlockNode(block_flow);
+ NGBlockNode node(block_flow);
RefPtr<NGLayoutResult> result =
NGBlockLayoutAlgorithm(node, constraint_space.Get()).Layout();
EXPECT_TRUE(result);
String expected_text("Hello World!");
- EXPECT_EQ(expected_text, ToNGInlineNode(node->FirstChild())->Text(0, 12));
+ EXPECT_EQ(expected_text, ToNGInlineNode(node.FirstChild()).Text(0, 12));
}
TEST_F(NGInlineLayoutTest, BlockWithTextAndAtomicInline) {
@@ -74,7 +74,7 @@ TEST_F(NGInlineLayoutTest, BlockWithTextAndAtomicInline) {
ToLayoutNGBlockFlow(target->GetLayoutObject());
RefPtr<NGConstraintSpace> constraint_space =
ConstraintSpaceForElement(block_flow);
- NGBlockNode* node = new NGBlockNode(block_flow);
+ NGBlockNode node(block_flow);
RefPtr<NGLayoutResult> result =
NGBlockLayoutAlgorithm(node, constraint_space.Get()).Layout();
@@ -83,7 +83,7 @@ TEST_F(NGInlineLayoutTest, BlockWithTextAndAtomicInline) {
String expected_text("Hello ");
expected_text.append(kObjectReplacementCharacter);
expected_text.append(".");
- EXPECT_EQ(expected_text, ToNGInlineNode(node->FirstChild())->Text(0, 8));
+ EXPECT_EQ(expected_text, ToNGInlineNode(node.FirstChild()).Text(0, 8));
// Delete the line box tree to avoid leaks in the test.
block_flow->DeleteLineBoxTree();
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_unpositioned_float.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698