Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
index acc60b002a9d608d8fb2192651432c4766a310a1..47925f9400589dc8b73b599f2b37628708a71fca 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
@@ -23,7 +23,7 @@ template <typename NGInputNodeType, typename NGBreakTokenType>
class CORE_EXPORT NGLayoutAlgorithm {
STACK_ALLOCATED();
public:
- NGLayoutAlgorithm(NGInputNodeType* node,
+ NGLayoutAlgorithm(NGInputNodeType node,
NGConstraintSpace* space,
NGBreakTokenType* break_token)
: node_(node),
@@ -55,21 +55,18 @@ class CORE_EXPORT NGLayoutAlgorithm {
}
NGConstraintSpace* MutableConstraintSpace() { return constraint_space_; }
- const ComputedStyle& Style() const {
- DCHECK(node_);
- return node_->Style();
- }
+ const ComputedStyle& Style() const { return node_.Style(); }
NGLogicalOffset ContainerBfcOffset() const {
DCHECK(container_builder_.BfcOffset().has_value());
return container_builder_.BfcOffset().value();
}
- virtual NGInputNodeType* Node() const { return node_; }
+ virtual NGInputNodeType Node() const { return node_; }
NGBreakTokenType* BreakToken() const { return break_token_; }
- Persistent<NGInputNodeType> node_;
+ NGInputNodeType node_;
NGConstraintSpace* constraint_space_;
// The break token from which we are currently resuming layout.

Powered by Google App Engine
This is Rietveld 408576698