Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h

Issue 2921463004: [LayoutNG] PODify NGLayoutInputNode and sub-classes. (Closed)
Patch Set: new ng-bot expectations Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
index ea810396094492b48ddffae0c2ea248ba8742ddd..ff21381b65db7a1e156aa4fc721734a486fdfbac 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
@@ -16,7 +16,7 @@ namespace blink {
class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragment {
public:
NGPhysicalTextFragment(LayoutObject* layout_object,
- const NGInlineNode* node,
+ const NGInlineNode node,
unsigned item_index,
unsigned start_offset,
unsigned end_offset,
@@ -27,8 +27,8 @@ class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragment {
start_offset_(start_offset),
end_offset_(end_offset) {}
- const NGInlineNode* Node() const { return node_; }
- StringView Text() const { return node_->Text(start_offset_, end_offset_); }
+ const NGInlineNode Node() const { return node_; }
+ StringView Text() const { return node_.Text(start_offset_, end_offset_); }
// The range of NGLayoutInlineItem.
unsigned ItemIndex() const { return item_index_; }
@@ -38,7 +38,7 @@ class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragment {
private:
// TODO(kojii): NGInlineNode is to access text content and NGLayoutInlineItem.
// Review if it's better to point them.
- Persistent<const NGInlineNode> node_;
+ const NGInlineNode node_;
unsigned item_index_;
unsigned start_offset_;
unsigned end_offset_;

Powered by Google App Engine
This is Rietveld 408576698