Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 2921463002: Tooltip for 'Stop refreshing' menu item (Closed)
Patch Set: naming issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
index 70dd58c8b124bed5d613e2028187b7cc29d9192c..4adb90394d2e3d9f64e7093508e13ccd31494236 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
@@ -331,7 +331,10 @@ public class ToolbarTablet
Resources resources = context.getResources();
if (v == mReloadButton) {
- description = resources.getString(R.string.menu_refresh);
+ description = (mReloadButton.getDrawable().getLevel()
+ == resources.getInteger(R.integer.reload_button_level_reload))
+ ? resources.getString(R.string.menu_refresh)
+ : resources.getString(R.string.menu_stop_refresh);
} else if (v == mBookmarkButton) {
description = resources.getString(R.string.menu_bookmark);
} else if (v == mSaveOfflineButton) {
@@ -439,11 +442,13 @@ public class ToolbarTablet
@Override
protected void updateReloadButtonVisibility(boolean isReloading) {
if (isReloading) {
- mReloadButton.setImageResource(R.drawable.btn_close);
+ mReloadButton.getDrawable().setLevel(
+ getResources().getInteger(R.integer.reload_button_level_stop));
mReloadButton.setContentDescription(getContext().getString(
R.string.accessibility_btn_stop_loading));
} else {
- mReloadButton.setImageResource(R.drawable.btn_toolbar_reload);
+ mReloadButton.getDrawable().setLevel(
+ getResources().getInteger(R.integer.reload_button_level_reload));
mReloadButton.setContentDescription(getContext().getString(
R.string.accessibility_btn_refresh));
}

Powered by Google App Engine
This is Rietveld 408576698