chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java - Issue 2921463002: Tooltip for 'Stop refreshing' menu item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java

Issue 2921463002: Tooltip for 'Stop refreshing' menu item (Closed)

Patch Set: naming issue Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java

index a47148394529fe121acbc6aa45001dad866d2bef..7489e4e2b8624be548805bc006b2555de9a3a657 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java

@@ -106,7 +106,10 @@ public class AppMenuIconRowFooter

} else if (itemId == R.id.info_menu_id) {

description = resources.getString(R.string.menu_page_info);

} else if (itemId == R.id.reload_menu_id) {

- description = resources.getString(R.string.menu_refresh);

+ description = (mReloadButton.getDrawable().getLevel()

+ == resources.getInteger(R.integer.reload_button_level_reload))

+ ? resources.getString(R.string.menu_refresh)

+ : resources.getString(R.string.menu_stop_refresh);

}

return AccessibilityUtil.showAccessibilityToast(context, v, description);

}

@@ -117,8 +120,8 @@ public class AppMenuIconRowFooter

public void loadingStateChanged(boolean isLoading) {

mReloadButton.getDrawable().setLevel(isLoading

- ? AppMenuPropertiesDelegate.RELOAD_BUTTON_LEVEL_STOP_LOADING

- : AppMenuPropertiesDelegate.RELOAD_BUTTON_LEVEL_RELOAD);

+ ? getResources().getInteger(R.integer.reload_button_level_stop)

+ : getResources().getInteger(R.integer.reload_button_level_reload));

mReloadButton.setContentDescription(isLoading

? mActivity.getString(R.string.accessibility_btn_stop_loading)

: mActivity.getString(R.string.accessibility_btn_refresh));