chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java - Issue 2921463002: Tooltip for 'Stop refreshing' menu item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 2921463002: Tooltip for 'Stop refreshing' menu item (Closed)

Patch Set: move constants to values.xml Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/drawable/btn_reload_stop.xml ('K') | « chrome/android/java/res/values/values.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

index aca842deb06045fff73d23167bdbf188a4a914bc..a2b232bb2246498df4fe2b20c5d1b12f75e0bdd2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

@@ -401,7 +401,10 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {

} else if (itemId == R.id.info_menu_id) {

description = resources.getString(R.string.menu_page_info);

} else if (itemId == R.id.reload_menu_id) {

- description = resources.getString(R.string.menu_refresh);

+ description = (menuItem.getIcon().getLevel()

+ == resources.getInteger(R.integer.reload_button_level_reload))

+ ? resources.getString(R.string.menu_refresh)

+ : resources.getString(R.string.menu_stop_refresh);

}

return AccessibilityUtil.showAccessibilityToast(context, view, description);

}