Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2921443002: Implement type inference for PropertyGet. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -173 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 6 chunks +40 lines, -15 lines 2 comments Download
M pkg/front_end/lib/src/base/instrumentation.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 4 chunks +28 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +33 lines, -18 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 5 chunks +0 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync_star.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync_star.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/do_not_infer_overridden_fields_that_explicitly_say_dynamic_infer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/do_not_infer_overridden_fields_that_explicitly_say_dynamic_infer.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_instantiation.dart View 2 chunks +19 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_instantiation.dart.strong.expect View 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_nested_generic_instantiation.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_nested_generic_instantiation.dart.strong.expect View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_custom.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_correctly_on_multiple_variables_declared_together.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_rhs_only_if_it_wont_conflict_with_overridden_fields2.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_statics_with_method_invocations.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_type_on_overridden_fields2.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_type_on_overridden_fields2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_type_on_overridden_fields4.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_type_on_overridden_fields4.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_3.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_3.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_in_library_cycle.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_infer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_infer.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_cascade.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off.dart.strong.expect View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off_via_interface.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_extract_method_tear_off_via_interface.dart.strong.expect View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_to_field_in_class.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/inference/propagate_inference_to_field_in_class.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively2.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively2.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-05-31 18:34:16 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2921443002/diff/1/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart File pkg/analyzer/test/src/task/strong/front_end_inference_test.dart (right): https://codereview.chromium.org/2921443002/diff/1/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart#newcode467 pkg/analyzer/test/src/task/strong/front_end_inference_test.dart:467: void _recordMethodTarget(int offset, Element element) { Maybe this ...
3 years, 6 months ago (2017-05-31 18:40:13 UTC) #3
Paul Berry
https://codereview.chromium.org/2921443002/diff/1/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart File pkg/analyzer/test/src/task/strong/front_end_inference_test.dart (right): https://codereview.chromium.org/2921443002/diff/1/pkg/analyzer/test/src/task/strong/front_end_inference_test.dart#newcode467 pkg/analyzer/test/src/task/strong/front_end_inference_test.dart:467: void _recordMethodTarget(int offset, Element element) { On 2017/05/31 18:40:13, ...
3 years, 6 months ago (2017-05-31 19:08:33 UTC) #4
Paul Berry
3 years, 6 months ago (2017-05-31 19:26:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
26c61e4d220998d8e2934cfc5cb0a3ae2457dc1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698