Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: appengine/swarming/ui/res/imp/common/common-behavior.html

Issue 2921433002: Add in similar load (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/taskpage/task-page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/ui/res/imp/common/common-behavior.html
diff --git a/appengine/swarming/ui/res/imp/common/common-behavior.html b/appengine/swarming/ui/res/imp/common/common-behavior.html
index 2b753162608abdd0073f3cdc396adf8f68691fb5..2c67bfcdd10fbab73a705b1d8dd560a0f3741de6 100644
--- a/appengine/swarming/ui/res/imp/common/common-behavior.html
+++ b/appengine/swarming/ui/res/imp/common/common-behavior.html
@@ -216,6 +216,8 @@
// {key:String, value:Array<String>}. If Array<String>, the Strings
// should be valid filters (e.g. "foo:bar").
// columns - Array<String> , the the column names that should be shown.
+ // Any trailing args after columns will be assumed to be strings that
+ // should be treated as valid filters.
_taskListLink: function(filters, columns) {
filters = filters || [];
columns = columns || [];
@@ -233,6 +235,10 @@
fArr.push(f);
}
});
+ // can't use .foreach, as arguments isn't really an Array.
+ for (var i = 2; i < arguments.length; i++) {
+ fArr.push(arguments[i]);
+ }
var obj = {
f: fArr,
c: columns,
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/taskpage/task-page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698