[vr] Close exit prompt when clicking on background

chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/macros.h"
 #include "base/test/scoped_task_environment.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h"
@@ skipping 273 matching lines @@
   manager_->OnExitPromptPrimaryButtonClicked();
   for (const auto& element : scene_->GetUiElements()) {
     SCOPED_TRACE(element->debug_id());
     bool should_be_visible =
         kElementsVisibleInBrowsing.find(element->debug_id()) !=
         kElementsVisibleInBrowsing.end();
     EXPECT_EQ(should_be_visible, element->visible());
   }
 }
 
+TEST_F(UiSceneManagerTest, BackplaneClickClosesExitPrompt) {
+  std::set<UiElementDebugId> visible_when_prompting = {kExitPrompt, kBackplane,
+                                                       kCeiling, kFloor};
+  MakeManager(kNotInCct, kNotInWebVr);
+
+  manager_->SetWebVrSecureOrigin(true);
+
+  // Initial state.
+  for (const auto& element : scene_->GetUiElements()) {
+    SCOPED_TRACE(element->debug_id());
+    bool should_be_visible =
+        kElementsVisibleInBrowsing.find(element->debug_id()) !=
+        kElementsVisibleInBrowsing.end();
+    EXPECT_EQ(should_be_visible, element->visible());
+  }
+
+  // Exit prompt visible state.
+  manager_->OnSecurityIconClicked();
+  for (const auto& element : scene_->GetUiElements()) {

[cjgrant, 2017/06/06 19:42:13]

Based on how many of these loops we have throughout tests, and the fact that
SCOPED_TRACE is our new friend, could we break out a module- or class-level
helper method, VerifyElementsVisible(std::set<elements>)?

This could probably be:
VerifyElementsVisible({kExitPrompt, kBackplane, kCeiling, kFloor});

[ymalik, 2017/06/06 21:11:58]

Done. Much cleaner.

+    SCOPED_TRACE(element->debug_id());
+    bool should_be_visible = visible_when_prompting.find(element->debug_id()) !=
+                             visible_when_prompting.end();
+    EXPECT_EQ(should_be_visible, element->visible());
+  }
+
+  // Back to initial state.
+  manager_->OnBackplaneClicked();
+  for (const auto& element : scene_->GetUiElements()) {

[cjgrant, 2017/06/06 19:42:13]

Originally I thought it's weird so many tests check which elements are visible
in normal browsing mode.  But I changed my mind, and I think it does make sense.
 If we used the helper method approach, doing so would be a one-liner. 
Thoughts?

[ymalik, 2017/06/06 21:11:58]

Agreed, we want to check the visibility of these elements with the case that a
unittest covers. 

+    SCOPED_TRACE(element->debug_id());
+    bool should_be_visible =
+        kElementsVisibleInBrowsing.find(element->debug_id()) !=
+        kElementsVisibleInBrowsing.end();
+    EXPECT_EQ(should_be_visible, element->visible());
+  }
+}
+
 TEST_F(UiSceneManagerTest, UiUpdatesForWebVR) {
   MakeManager(kNotInCct, kInWebVr);
 
   manager_->SetWebVrSecureOrigin(true);
   manager_->SetAudioCapturingIndicator(true);
   manager_->SetVideoCapturingIndicator(true);
   manager_->SetScreenCapturingIndicator(true);
 
   // All elements should be hidden.
   for (const auto& element : scene_->GetUiElements()) {
@@ skipping 45 matching lines @@
 
   manager_->SetAudioCapturingIndicator(false);
   manager_->SetVideoCapturingIndicator(false);
   manager_->SetScreenCapturingIndicator(false);
 
   EXPECT_FALSE(IsVisible(kAudioCaptureIndicator));
   EXPECT_FALSE(IsVisible(kVideoCaptureIndicator));
   EXPECT_FALSE(IsVisible(kScreenCaptureIndicator));
 }
 }  // namespace vr_shell