Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: DEPS

Issue 2921353002: Refactor how we fetch Telemetry deps conditionally (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/conditionally_execute » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used to manage the dependencies of the Chromium src repo. It is 1 # This file is used to manage the dependencies of the Chromium src repo. It is
2 # used by gclient to determine what version of each dependency to check out, and 2 # used by gclient to determine what version of each dependency to check out, and
3 # where. 3 # where.
4 # 4 #
5 # For more information, please refer to the official documentation: 5 # For more information, please refer to the official documentation:
6 # https://sites.google.com/a/chromium.org/dev/developers/how-tos/get-the-code 6 # https://sites.google.com/a/chromium.org/dev/developers/how-tos/get-the-code
7 # 7 #
8 # When adding a new dependency, please update the top-level .gitignore file 8 # When adding a new dependency, please update the top-level .gitignore file
9 # to list the dependency's destination directory. 9 # to list the dependency's destination directory.
10 # 10 #
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 '--bucket', 'chromium-nodejs', 883 '--bucket', 'chromium-nodejs',
884 '-s', 'src/third_party/node/node_modules.tar.gz.sha1', 884 '-s', 'src/third_party/node/node_modules.tar.gz.sha1',
885 ], 885 ],
886 }, 886 },
887 887
888 # Download Telemetry's binary dependencies 888 # Download Telemetry's binary dependencies
889 { 889 {
890 'name': 'fetch_telemetry_binary_dependencies', 890 'name': 'fetch_telemetry_binary_dependencies',
891 'pattern': '.', 891 'pattern': '.',
892 'action': [ 'python', 892 'action': [ 'python',
893 'tools/perf/conditionally_execute'
894 '--gyp-condition', 'fetch_telemetry_dependencies=1',
nednguyen 2017/06/05 21:31:47 With this, we can remove the conditioning code in
893 'src/third_party/catapult/telemetry/bin/fetch_telemetry_binary_d ependencies', 895 'src/third_party/catapult/telemetry/bin/fetch_telemetry_binary_d ependencies',
894 ], 896 ],
895 }, 897 },
896 898
899 # Download all WPR archives in tools/perf/
900 {
901 'name': 'fetch_perf_wpr_archives',
902 'pattern': '.',
903 'action': [ 'python',
904 'tools/perf/conditionally_execute'
905 '--gyp-condition', 'fetch_telemetry_dependencies=1',
906 'tools/perf/fetch_benchmark_deps.py', '--force'
907 ],
908 },
909
897 # Download checkstyle for use in PRESUBMIT for Java changes. 910 # Download checkstyle for use in PRESUBMIT for Java changes.
898 # TODO(jbudorick): Move this back down to the android section of hooks_os 911 # TODO(jbudorick): Move this back down to the android section of hooks_os
899 # once it's no longer necessary for the chromium_presubmit bot. 912 # once it's no longer necessary for the chromium_presubmit bot.
900 { 913 {
901 'name': 'checkstyle', 914 'name': 'checkstyle',
902 'pattern': '.', 915 'pattern': '.',
903 'action': [ 'download_from_google_storage', 916 'action': [ 'download_from_google_storage',
904 '--no_resume', 917 '--no_resume',
905 '--no_auth', 918 '--no_auth',
906 '--bucket', 'chromium-android-tools/checkstyle', 919 '--bucket', 'chromium-android-tools/checkstyle',
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
1180 } 1193 }
1181 1194
1182 recursedeps = [ 1195 recursedeps = [
1183 # buildtools provides clang_format, libc++, and libc++abi 1196 # buildtools provides clang_format, libc++, and libc++abi
1184 'src/buildtools', 1197 'src/buildtools',
1185 # android_tools manages the NDK. 1198 # android_tools manages the NDK.
1186 'src/third_party/android_tools', 1199 'src/third_party/android_tools',
1187 # ANGLE manages DEPS that it also owns the build files for, such as dEQP. 1200 # ANGLE manages DEPS that it also owns the build files for, such as dEQP.
1188 ("src/third_party/angle", "DEPS.chromium"), 1201 ("src/third_party/angle", "DEPS.chromium"),
1189 ] 1202 ]
OLDNEW
« no previous file with comments | « no previous file | tools/perf/conditionally_execute » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698