Issue 292123015: Remove WebContents::IsActiveEntry from Instant Extended and from WebContents.

Issue 292123015: Remove WebContents::IsActiveEntry from Instant Extended and from WebContents. (Closed)

Created:
6 years, 7 months ago by Avi (use Gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Jered, nasko, kmadhusu

CC:
chromium-reviews, nasko+codewatch_chromium.org, creis+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jam, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove WebContents::IsActiveEntry from Instant Extended and from WebContents. BUG=371150 TEST=no visible change to instant extended Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273965

Patch Set 1 #

Patch Set 2 : perhaps this? #

Patch Set 3 : missed one #

Patch Set 4 : trying again #

Patch Set 5 : fix #

Patch Set 6 : done? #

Total comments: 2

Patch Set 7 : style #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -143 lines)			Patch
M	chrome/browser/ui/search/search_ipc_router.h	View	1 2 3	3 chunks	+24 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router.cc	View	1 2 3	15 chunks	+34 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_unittest.cc	View	1 2 3 4 5 6	23 chunks	+42 lines, -54 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper_unittest.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2 3 4 5	2 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox.cc	View	1 2 3	5 chunks	+22 lines, -19 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2 3 4	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/public/browser/web_contents.h	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

lgtm. Thanks for working on this. I didn't test the last patch. I am assuming ...

6 years, 6 months ago (2014-05-30 18:05:38 UTC) #2

Avi (use Gerrit)

The only real change from last time was the change we discussed. (The rest was ...

6 years, 6 months ago (2014-05-30 18:10:23 UTC) #3

Avi (use Gerrit)

Jered: can you look at all the search stuff? Kausalya approves of this. Nasko: IPC ...

6 years, 6 months ago (2014-05-30 18:12:07 UTC) #4

Jered

On 2014/05/30 18:12:07, Avi wrote: > Jered: can you look at all the search stuff? ...

6 years, 6 months ago (2014-05-30 18:14:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/292123015/120001

6 years, 6 months ago (2014-05-30 18:30:43 UTC) #8

Message was sent while issue was closed.

Change committed as 273965

Expand Messages | Collapse Messages