Issue 292123014: Ash system tray delegate for Linux

Issue 292123014: Ash system tray delegate for Linux (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher

Modified:
6 years, 6 months ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_ash: Create a SystemTrayDelegateLinux. This silences the false positive update warning, and starts with parts of Window's SystemTrayDelegate as a template to build on. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273967

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Total comments: 7

Patch Set 3 : jamescook nits #

Patch Set 4 : Remove parts of another patch that accidently got committed. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -12 lines)			Patch
M	chrome/app/resources/locale_settings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_views.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/ash/system_tray_delegate_linux.h	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/ash/system_tray_delegate_linux.cc	View	1 2	7 chunks	+15 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/ash/system_tray_delegate_win.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM with a few nits/questions https://codereview.chromium.org/292123014/diff/20001/chrome/browser/ui/ash/system_tray_delegate_linux.cc File chrome/browser/ui/ash/system_tray_delegate_linux.cc (right): https://codereview.chromium.org/292123014/diff/20001/chrome/browser/ui/ash/system_tray_delegate_linux.cc#newcode15 chrome/browser/ui/ash/system_tray_delegate_linux.cc:15: #include "base/logging.h" Is this ...

6 years, 6 months ago (2014-05-29 21:49:11 UTC) #2

Elliot Glaysher

https://codereview.chromium.org/292123014/diff/20001/chrome/browser/ui/ash/system_tray_delegate_linux.cc File chrome/browser/ui/ash/system_tray_delegate_linux.cc (right): https://codereview.chromium.org/292123014/diff/20001/chrome/browser/ui/ash/system_tray_delegate_linux.cc#newcode18 chrome/browser/ui/ash/system_tray_delegate_linux.cc:18: #include "chrome/browser/lifetime/application_lifetime.h" On 2014/05/29 21:49:11, James Cook wrote: > ...

6 years, 6 months ago (2014-05-30 19:43:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/292123014/60001

6 years, 6 months ago (2014-05-30 19:45:59 UTC) #5

Message was sent while issue was closed.

Change committed as 273967

Expand Messages | Collapse Messages