Issue 292123012: Add an error for empty script names in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292123012: Add an error for empty script names in GN. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add an error for empty script names in GN. I accidentally passed an empty string here and got a weird error processing the path. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272573

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	tools/gn/action_target_generator.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 7 months ago (2014-05-23 18:58:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r272573 (presubmit successful).