third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h - Issue 2921223002: [CSS Typed OM] Hook up getting CSSUnitValues from inline StylePropertyMaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h

Issue 2921223002: [CSS Typed OM] Hook up getting CSSUnitValues from inline StylePropertyMaps (Closed)

Patch Set: Fix missed LayoutTests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h b/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h

index 55af6539cc6043c826ef56cbf60dbd8ec9d85ec2..6344c2fe57f21f6c1e163fd6351353450389155f 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h

@@ -22,10 +22,7 @@ class CORE_EXPORT CSSNumericValue : public CSSStyleValue {

public:

static CSSNumericValue* parse(const String& css_text, ExceptionState&);

- static CSSNumericValue* FromCSSValue(const CSSValue&) {

- // TODO(meade): Implement.

- return nullptr;

- }

+ static CSSNumericValue* FromCSSValue(const CSSPrimitiveValue&);

virtual CSSNumericValue* add(const CSSNumericValue*, ExceptionState&) {

// TODO(meade): Implement.