Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: components/metrics/metrics_log_base.h

Issue 292113003: Remove num_events_ member from MetricsLogBase. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log.cc ('k') | components/metrics/metrics_log_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log_base.h
===================================================================
--- components/metrics/metrics_log_base.h (revision 271493)
+++ components/metrics/metrics_log_base.h (working copy)
@@ -70,7 +70,10 @@
// record. Must only be called after CloseLog() has been called.
void GetEncodedLog(std::string* encoded_log);
- int num_events() { return num_events_; }
+ int num_events() const {
+ return uma_proto_.omnibox_event_size() +
+ uma_proto_.user_action_event_size();
+ }
void set_hardware_class(const std::string& hardware_class) {
uma_proto_.mutable_system_profile()->mutable_hardware()->set_hardware_class(
@@ -87,9 +90,6 @@
return &uma_proto_;
}
- // TODO(isherman): Remove this once the XML pipeline is outta here.
- int num_events_; // the number of events recorded in this log
-
private:
// locked_ is true when record has been packed up for sending, and should
// no longer be written to. It is only used for sanity checking and is
« no previous file with comments | « chrome/browser/metrics/metrics_log.cc ('k') | components/metrics/metrics_log_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698