Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292113003: Remove num_events_ member from MetricsLogBase. (Closed)

Created:
6 years, 7 months ago by Alexei Svitkine (slow)
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

Remove num_events_ member from MetricsLogBase. BUG=375177 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M chrome/browser/metrics/metrics_log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/metrics/metrics_log_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/metrics/metrics_log_base.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alexei Svitkine (slow)
6 years, 7 months ago (2014-05-20 09:39:23 UTC) #1
Ilya Sherman
LGTM :)
6 years, 7 months ago (2014-05-20 09:46:09 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-20 09:46:31 UTC) #3
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-20 09:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/292113003/1
6 years, 7 months ago (2014-05-20 09:47:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 11:21:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 12:15:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155343)
6 years, 7 months ago (2014-05-20 12:15:04 UTC) #8
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-20 12:24:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/292113003/1
6 years, 7 months ago (2014-05-20 12:24:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 13:18:59 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:54:03 UTC) #12
Message was sent while issue was closed. 
Change committed as 271667

Powered by Google App Engine
This is Rietveld 408576698