[Mac] Touch Bar Support for Dialogs

ui/base/cocoa/touch_bar_util.h

+// Copyright 2017 The Chromium Authors. All rights reserved.

[Robert Sesek, 2017/06/06 14:52:35]

Unittests for this file?

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_COCOA_TOUCH_BAR_UTIL_H
+#define UI_BASE_COCOA_TOUCH_BAR_UTIL_H
+
+#import <Cocoa/Cocoa.h>
+
+#include "ui/base/ui_base_export.h"
+
+namespace ui {
+

[Robert Sesek, 2017/06/06 14:52:36]

Optional: It may be handy to add a function like:

Class NSTouchBar() {
  return NSClassFromString(@"NSTouchBar");
}

To replace:

base::scoped_nsobject<NSTouchBar> touchBar(
      [[NSClassFromString(@"NSTouchBar") alloc] init]);

With:

base::scoped_nsobject<NSTouchBar> touchBar(
      [[ui::NSTouchBar() alloc] init]);

And the same with NSCustomTouchBarItem.

[spqchan, 2017/06/06 19:34:50]

Done.

+// Returns a stylized blue button for the touch bar. The button performs
+// |action| from the |target|.
+UI_BASE_EXPORT NSButton* CreateBlueTouchBarButton(NSString* title,

[Robert Sesek, 2017/06/06 14:52:35]

These functions shouldn't be named "Create" unless they return strongly
referenced objects/scoped_nsobject (per the "create" rule).

[spqchan, 2017/06/06 19:34:50]

What should I use? GetBlueTouchBarButton or just BlueTouchBarButton?

[Robert Sesek, 2017/06/06 20:14:59]

Yes, I'd use GetBlueTouchBarButton().

+                                                  id target,
+                                                  SEL action);
+
+// Creates a Touch Bar identifier with the given |id|.
+UI_BASE_EXPORT NSString* CreateTouchBarId(NSString* touch_bar_id);
+
+// Creates a Touch Bar Item identifier.
+UI_BASE_EXPORT NSString* CreateTouchBarItemId(NSString* touch_bar_id,
+                                              NSString* item_id);
+
+}  // namespace ui
+
+#endif  // UI_BASE_COCOA_TOUCH_BAR_UTIL_H