chrome/browser/ui/cocoa/dialog_text_field_editor.h - Issue 2921083003: [Mac] Touch Bar Support for Dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/dialog_text_field_editor.h

Issue 2921083003: [Mac] Touch Bar Support for Dialogs (Closed)

Patch Set: nits Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_DIALOG_TEXT_FIELD__EDITOR_H_

	6 #define CHROME_BROWSER_UI_COCOA_DIALOG_TEXT_FIELD__EDITOR_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 // This class is used to customize the field editors for dialog textfields.

	11 // It intercepts touch bar methods to prevent the textfield's touch Bar from
	Robert Sesek 2017/06/06 14:52:35 nit: capitalization of "touch Bar" is off. nit: capitalization of "touch Bar" is off. spqchan 2017/06/06 19:34:50 Done. Show quoted text On 2017/06/06 14:52:35, Robert Sesek wrote: > nit: capitalization of "touch Bar" is off. Done.
	12 // overriding the dialog's touch bar.

	13 //

	14 // TODO(spqchan): Add the textfield's candidate list to the touch bar. I've

	15 // tried to combine the parent's touch bar with the dialog's, but the result

	16 // was buggy.

	17 @interface DialogTextFieldEditor : NSTextView

	18

	19 @end

	20

	21 #endif // CHROME_BROWSER_UI_COCOA_DIALOG_TEXT_FIELD__EDITOR_H_

OLD	NEW