Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: media/audio/audio_output_proxy.cc

Issue 2921033002: Replace deprecated base::NonThreadSafe in /media/audio in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_output_proxy.cc
diff --git a/media/audio/audio_output_proxy.cc b/media/audio/audio_output_proxy.cc
index b215b47de1bd8f2d27f847edb68a5fd6d3c37a86..c3551b1096bc1e05db09ecf5d7712ead7b7bd302 100644
--- a/media/audio/audio_output_proxy.cc
+++ b/media/audio/audio_output_proxy.cc
@@ -18,12 +18,12 @@ AudioOutputProxy::AudioOutputProxy(
}
AudioOutputProxy::~AudioOutputProxy() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(state_ == kCreated || state_ == kClosed) << "State is: " << state_;
}
bool AudioOutputProxy::Open() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK_EQ(state_, kCreated);
if (!dispatcher_ || !dispatcher_->OpenStream()) {
@@ -36,7 +36,7 @@ bool AudioOutputProxy::Open() {
}
void AudioOutputProxy::Start(AudioSourceCallback* callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// We need to support both states since the callback may not handle OnError()
// immediately (or at all). It's also possible for subsequent StartStream()
@@ -52,7 +52,7 @@ void AudioOutputProxy::Start(AudioSourceCallback* callback) {
}
void AudioOutputProxy::Stop() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (state_ != kPlaying)
return;
@@ -62,7 +62,7 @@ void AudioOutputProxy::Stop() {
}
void AudioOutputProxy::SetVolume(double volume) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
volume_ = volume;
if (dispatcher_)
@@ -70,12 +70,12 @@ void AudioOutputProxy::SetVolume(double volume) {
}
void AudioOutputProxy::GetVolume(double* volume) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
*volume = volume_;
}
void AudioOutputProxy::Close() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(state_ == kCreated || state_ == kOpenError || state_ == kOpened ||
state_ == kStartError);
« no previous file with comments | « media/audio/audio_output_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698