Issue 292103006: TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadS…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292103006: TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadS… (Closed)

Created:
6 years, 7 months ago by ernstm

Modified:
6 years, 7 months ago

Reviewers:
Jeffrey Yasskin, Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadStats. This should now be fixed for real: https://codereview.chromium.org/289163004/ R=jyasskin@chromium.org,glider@chromium.org NOTRY=True BUG=370244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272207

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	tools/valgrind/tsan_v2/suppressions.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

ernstm

On 2014/05/20 22:41:51, ernstm wrote: > PTAL Does anybody know why this patch fails to ...

6 years, 7 months ago (2014-05-21 00:41:43 UTC) #2

Jeffrey Yasskin

On 2014/05/21 00:41:43, ernstm wrote: > On 2014/05/20 22:41:51, ernstm wrote: > > PTAL > ...

6 years, 7 months ago (2014-05-21 00:46:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/292103006/20001

6 years, 7 months ago (2014-05-22 16:45:21 UTC) #5

Message was sent while issue was closed.

Change committed as 272207