Enable keyboard filters in PNaCl client

Enable keyboard filters in PNaCl client

Previously keyboard filters were selected using the per-platform
filename exclusion rules, and that doesn't work for PNaCl plugin. Now
both Mac and ChromeOS filters are compiled into the PNaCl plugin and
selected in runtime.

BUG=276739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271997

[Jamie, 2014-05-20 18:32:12]

There seem to have been a lot of changes to the ChromeOS handler, which is
surprising given the CL description (the changes to the Mac equivalent seem more
in-line with what I would expect). Assuming all of those changes are necessary
for this CL, can you provide a summary of what they are in the description?

https://codereview.chromium.org/292103004/diff/60001/remoting/client/plugin/n...
File remoting/client/plugin/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/292103004/diff/60001/remoting/client/plugin/n...
remoting/client/plugin/normalizing_input_filter_cros.cc:108: // If |event| is
|deferred_keydown_event_| auto-repeat then assume
s/auto-repeat/repeat/ (or vice-versa in the next comment, for consistency). Or,
if they are describing different scenarios, please make it more explicit.

[Sergey Ulanov, 2014-05-20 18:45:07]

On 2014/05/20 18:32:12, Jamie wrote:
> There seem to have been a lot of changes to the ChromeOS handler, which is
> surprising given the CL description (the changes to the Mac equivalent seem
more
> in-line with what I would expect). Assuming all of those changes are necessary
> for this CL, can you provide a summary of what they are in the description?

There are zero changes in the logic. The problem is that all members were
previously defined inline, inside the class, so I had to change indentation when
moving class declaration to the .h file. I'll try upload a separate patches, to
make it easier to review.

[Sergey Ulanov, 2014-05-20 18:49:28]

now uploaded patch sets 3 and 4:
 3: same code old indentation.
 4: updated indentation (same as patch set 2 you looked at).

[Sergey Ulanov, 2014-05-20 18:51:20]

https://codereview.chromium.org/292103004/diff/60001/remoting/client/plugin/n...
File remoting/client/plugin/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/292103004/diff/60001/remoting/client/plugin/n...
remoting/client/plugin/normalizing_input_filter_cros.cc:108: // If |event| is
|deferred_keydown_event_| auto-repeat then assume
On 2014/05/20 18:32:12, Jamie wrote:
> s/auto-repeat/repeat/ (or vice-versa in the next comment, for consistency).
Or,
> if they are describing different scenarios, please make it more explicit.

Done.

[Jamie, 2014-05-20 20:57:49]

Thanks for taking the time to split this up. LGTM.

[Sergey Ulanov, 2014-05-21 01:36:27]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-05-21 01:41:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyu@chromium.org/292103004/110001

[commit-bot: I haz the power, 2014-05-21 20:02:40]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-21 22:49:23]

Change committed as 271997