Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: extensions/renderer/api_event_handler_unittest.cc

Issue 2921013002: [Extensions Bindings] Return result from event dispatch (Closed)
Patch Set: add listener count todo Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_event_handler.cc ('k') | extensions/renderer/event_emitter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_event_handler_unittest.cc
diff --git a/extensions/renderer/api_event_handler_unittest.cc b/extensions/renderer/api_event_handler_unittest.cc
index fc66f833c6452cc094c6123fbcf21835feb81180..b2ccef06be31a090a1f6118b644b3fc87f89864f 100644
--- a/extensions/renderer/api_event_handler_unittest.cc
+++ b/extensions/renderer/api_event_handler_unittest.cc
@@ -40,6 +40,7 @@ class APIEventHandlerTest : public APIBindingTest {
APIBindingTest::SetUp();
handler_ = base::MakeUnique<APIEventHandler>(
base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle),
base::Bind(&DoNothingOnEventListenersChanged));
}
@@ -556,6 +557,7 @@ TEST_F(APIEventHandlerTest, TestEventListenersThrowingExceptions) {
SetHandler(base::MakeUnique<APIEventHandler>(
base::Bind(run_js_and_expect_error),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle),
base::Bind(&DoNothingOnEventListenersChanged)));
v8::HandleScope handle_scope(isolate());
@@ -627,7 +629,8 @@ TEST_F(APIEventHandlerTest, TestEventListenersThrowingExceptions) {
TEST_F(APIEventHandlerTest, CallbackNotifications) {
MockEventChangeHandler change_handler;
SetHandler(base::MakeUnique<APIEventHandler>(
- base::Bind(&RunFunctionOnGlobalAndIgnoreResult), change_handler.Get()));
+ base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle), change_handler.Get()));
v8::HandleScope handle_scope(isolate());
@@ -914,6 +917,7 @@ TEST_F(APIEventHandlerTest, TestCreateCustomEvent) {
MockEventChangeHandler change_handler;
APIEventHandler handler(base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle),
change_handler.Get());
v8::Local<v8::Object> event = handler.CreateAnonymousEventInstance(context);
@@ -962,6 +966,7 @@ TEST_F(APIEventHandlerTest, TestCreateCustomEventWithCyclicDependency) {
MockEventChangeHandler change_handler;
APIEventHandler handler(base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle),
change_handler.Get());
v8::Local<v8::Object> event = handler.CreateAnonymousEventInstance(context);
@@ -988,6 +993,7 @@ TEST_F(APIEventHandlerTest, TestUnmanagedEvents) {
v8::Local<v8::Context> context) { ADD_FAILURE(); };
APIEventHandler handler(base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
+ base::Bind(&RunFunctionOnGlobalAndReturnHandle),
base::Bind(fail_on_notified));
const char kEventName[] = "alpha";
« no previous file with comments | « extensions/renderer/api_event_handler.cc ('k') | extensions/renderer/event_emitter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698