Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: extensions/renderer/event_emitter_unittest.cc

Issue 2921013002: [Extensions Bindings] Return result from event dispatch (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "extensions/renderer/event_emitter.h"
6
7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h"
9 #include "base/values.h"
10 #include "extensions/renderer/api_binding_test.h"
11 #include "extensions/renderer/api_binding_test_util.h"
12 #include "extensions/renderer/api_event_listeners.h"
13 #include "gin/handle.h"
14
15 namespace extensions {
16 namespace {
17
18 void DoNothingOnListenerChange(binding::EventListenersChanged changed,
19 const base::DictionaryValue* filter,
20 bool was_manual,
21 v8::Local<v8::Context> context) {}
22
23 } // namespace
24
25 using EventEmitterUnittest = APIBindingTest;
26
27 TEST_F(EventEmitterUnittest, TestDispatchMethod) {
28 v8::HandleScope handle_scope(isolate());
29 v8::Local<v8::Context> context = MainContext();
30
31 auto listeners = base::MakeUnique<UnfilteredEventListeners>(
32 base::Bind(&DoNothingOnListenerChange), binding::kNoListenerMax);
33
34 gin::Handle<EventEmitter> event = gin::CreateHandle(
35 isolate(),
36 new EventEmitter(false, std::move(listeners),
37 base::Bind(&RunFunctionOnGlobalAndIgnoreResult),
38 base::Bind(&RunFunctionOnGlobalAndReturnHandle)));
39
40 v8::Local<v8::Value> v8_event = event.ToV8();
41
42 const char kAddListener[] =
43 "(function(event, listener) { event.addListener(listener); })";
44 v8::Local<v8::Function> add_listener_function =
45 FunctionFromString(context, kAddListener);
46
47 auto add_listener = [context, v8_event,
48 add_listener_function](base::StringPiece listener) {
49 v8::Local<v8::Function> listener_function =
50 FunctionFromString(context, listener);
51 v8::Local<v8::Value> args[] = {v8_event, listener_function};
52 RunFunction(add_listener_function, context, arraysize(args), args);
53 };
54
55 const char kListener1[] =
56 "(function() {\n"
57 " this.eventArgs1 = Array.from(arguments);\n"
58 " return 'listener1';\n"
59 "})";
60 add_listener(kListener1);
61 const char kListener2[] =
62 "(function() {\n"
63 " this.eventArgs2 = Array.from(arguments);\n"
64 " return {listener: 'listener2'};\n"
65 "})";
66 add_listener(kListener2);
67
68 const char kDispatch[] =
69 "(function(event) {\n"
70 " return event.dispatch('arg1', 2);\n"
71 "})";
72 v8::Local<v8::Value> dispatch_args[] = {v8_event};
73 v8::Local<v8::Value> dispatch_result =
74 RunFunctionOnGlobal(FunctionFromString(context, kDispatch), context,
75 arraysize(dispatch_args), dispatch_args);
76
77 const char kExpectedEventArgs[] = "[\"arg1\",2]";
78 EXPECT_EQ(kExpectedEventArgs, GetStringPropertyFromObject(
79 context->Global(), context, "eventArgs1"));
80 EXPECT_EQ(kExpectedEventArgs, GetStringPropertyFromObject(
81 context->Global(), context, "eventArgs2"));
82 EXPECT_EQ("{\"results\":[\"listener1\",{\"listener\":\"listener2\"}]}",
83 V8ToString(dispatch_result, context));
84 }
85
86 } // namespace extensions
OLDNEW
« extensions/renderer/event_emitter.cc ('K') | « extensions/renderer/event_emitter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698