Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2920963002: GN: Add an explicit gn arg for recovery in CFI (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 17f4d9633f0e141f84c0dfe130de02982e79dead..b005a9f2fd3df59fd74022b7d7c742783b3fa4fe 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -67,10 +67,13 @@ declare_args() {
# https://crbug.com/701919
use_cfi_icall = false
- # By default, Control Flow Integrity will crash the program if it detects a
- # violation. Set this to true to print detailed diagnostics instead.
+ # Print detailed diagnostics when Control Flow Integrity detects a violation.
use_cfi_diag = false
+ # Let Control Flow Integrity continue execution instead of crashing when
+ # printing diagnostics (use_cfi_diag = true).
+ use_cfi_recover = false
Dirk Pranke 2017/06/07 19:42:12 Should we have an assert somewhere that `!use_cfi_
Michael Achenbach 2017/06/07 20:59:32 Can add that tomorrow...
Michael Achenbach 2017/06/08 10:58:38 Done in patch 3. Added it at the end of this file
+
# Compile for fuzzing with LLVM LibFuzzer.
# See http://www.chromium.org/developers/testing/libfuzzer
use_libfuzzer = false
@@ -122,6 +125,7 @@ if (current_toolchain != default_toolchain) {
sanitizer_coverage_flags = ""
use_afl = false
use_cfi_diag = false
+ use_cfi_recover = false
use_custom_libcxx = false
use_drfuzz = false
use_libfuzzer = false
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698