Auto-always/never can at most triggered twice (new translate infobar)

components/translate/core/browser/translate_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 69 matching lines @@
  public:
   static const char kPrefLanguageProfile[];
   static const char kPrefTranslateSiteBlacklist[];
   static const char kPrefTranslateWhitelists[];
   static const char kPrefTranslateDeniedCount[];
   static const char kPrefTranslateIgnoredCount[];
   static const char kPrefTranslateAcceptedCount[];
   static const char kPrefTranslateBlockedLanguages[];
   static const char kPrefTranslateLastDeniedTimeForLanguage[];
   static const char kPrefTranslateTooOftenDeniedForLanguage[];
+  static const char kPrefTranslateAutoAlwaysCount[];

[Marti Wong, 2017/06/02 07:37:13]

2 questions:
- Do I need someone's approval for adding a new pref?
- AutoAlwaysCount, AutoNeverCount are used in android only.
  Do I need #if defined(OS_ANDROID) for them?

[groby-ooo-7-16, 2017/06/07 17:02:49]

Prefs don't need approval (AFAIK :). If they're Android-only, yes, you should
#ifdef them... but - should they be Android only?

[Marti Wong, 2017/06/09 03:28:26]

Talked to Yana.
These are for Android only, at least for now.
So I will use '#if defined'.
We could remove '#if defined' in case other platform needs it in future.

+  static const char kPrefTranslateAutoNeverCount[];
 
   // |preferred_languages_pref| is only used on Chrome OS, other platforms must
   // pass NULL.
   TranslatePrefs(PrefService* user_prefs,
                  const char* accept_languages_pref,
                  const char* preferred_languages_pref);
 
   // Checks if the translate feature is enabled.
   bool IsEnabled() const;
 
@@ skipping 42 matching lines @@
   void IncrementTranslationIgnoredCount(const std::string& language);
   void ResetTranslationIgnoredCount(const std::string& language);
 
   // These methods are used to track how many times the user has accepted the
   // translation for a specific language. (So we can present a UI to white-list
   // that language if the user keeps accepting translations).
   int GetTranslationAcceptedCount(const std::string& language) const;
   void IncrementTranslationAcceptedCount(const std::string& language);
   void ResetTranslationAcceptedCount(const std::string& language);
 
+  // These methods are used to track how many times the auto-always translation
+  // has been triggered for a specific language.
+  int GetTranslationAutoAlwaysCount(const std::string& language) const;
+  void IncrementTranslationAutoAlwaysCount(const std::string& language);
+  void ResetTranslationAutoAlwaysCount(const std::string& language);
+
+  // These methods are used to track how many times the auto-never translation
+  // has been triggered for a specific language.
+  int GetTranslationAutoNeverCount(const std::string& language) const;
+  void IncrementTranslationAutoNeverCount(const std::string& language);
+  void ResetTranslationAutoNeverCount(const std::string& language);
+
   // Update the last time on closing the Translate UI without translation.
   void UpdateLastDeniedTime(const std::string& language);
 
   // Returns true if translation is denied too often.
   bool IsTooOftenDenied(const std::string& language) const;
 
   // Resets the prefs of denial state. Only used internally for diagnostics.
   void ResetDenialState();
 
   // Gets the language list of the language settings.
@@ skipping 45 matching lines @@
   // Path to the preference storing the accept languages.
   const std::string accept_languages_pref_;
 #if defined(OS_CHROMEOS)
   // Path to the preference storing the preferred languages.
   // Only used on ChromeOS.
   std::string preferred_languages_pref_;
 #endif
 
   // Retrieves the dictionary mapping the number of times translation has been
   // denied for a language, creating it if necessary.
   base::DictionaryValue* GetTranslationDeniedCountDictionary();

[Marti Wong, 2017/06/02 07:37:13]

Should I add "const" at the end of this line?

[groby-ooo-7-16, 2017/06/07 17:02:49]

Probably yes. 

Sidebar: Either solution is iffy. const is technically correct, since it doesn't
allow the object to be modified. And yet, misleading, since it returns a handle
to global state that can be modified. So... ¯\_(ツ)_/¯

[Marti Wong, 2017/06/09 03:28:26]

It seems this functions are never been used.
I will leave it untouched by now.
And see if we need to clean them up in another CL.

 
   // Retrieves the dictionary mapping the number of times translation has been
   // accepted for a language, creating it if necessary.
   base::DictionaryValue* GetTranslationAcceptedCountDictionary() const;
 
+  // Retrieves the dictionary mapping the number of times auto-always translate
+  // has been triggered for a language, creating it if necessary.
+  base::DictionaryValue* GetTranslateAutoAlwaysCountDictionary() const;
+
+  // Retrieves the dictionary mapping the number of times auto-never translate
+  // has been triggered for a language, creating it if necessary.
+  base::DictionaryValue* GetTranslationAutoNeverCountDictionary() const;

[Marti Wong, 2017/06/09 03:28:26]

Removed.  functions never been used.

+
   PrefService* prefs_;  // Weak.
 
   std::string country_;  // The country the app runs in.
 
   DISALLOW_COPY_AND_ASSIGN(TranslatePrefs);
 };
 
 }  // namespace translate
 
 #endif  // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_