Switch CandidateSession to use lists rather than vectors.

Switch CandidateSession to use lists rather than vectors.

This makes it possible to add candidate configurations at either the
back (least-preferred) or front (most-preferred) of each channel's
candidate list.

This CL also disables VP9, by default, in candidate session
configurations, replaces DisableVideoCodec with 
EnableVideoCodec, and makes the Enable/Disable<foo>Codec
helpers members of CandidateSessionConfig..

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272324

[Wez, 2014-05-20 20:25:17]

PTAL

[Sergey Ulanov, 2014-05-21 03:34:06]

It should be possible to prepend elements to vector, you just have to use
insert() instead of push_front(). Or is the concern that insert(0,_) is O(N)?
Prepending is faster with with lists, but copying is faster for vectors, so it's
not clear what's would be better overall. But in any case these lists are tiny,
so it's doesn't matter much. Thus LGTM.

[Wez, 2014-05-21 03:35:22]

On 2014/05/21 03:34:06, Sergey Ulanov wrote:
> It should be possible to prepend elements to vector, you just have to use
> insert() instead of push_front(). Or is the concern that insert(0,_) is O(N)?
> Prepending is faster with with lists, but copying is faster for vectors, so
it's
> not clear what's would be better overall. But in any case these lists are
tiny,
> so it's doesn't matter much. Thus LGTM.

insert() ends up making for more complicated calling code so, given the sizes of
these, I thought list<> would be simpler.

[Wez, 2014-05-21 03:35:36]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-21 03:39:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/292093002/1

[commit-bot: I haz the power, 2014-05-21 09:42:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-21 10:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 10:24:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Wez, 2014-05-21 17:35:27]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:57:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/292093002/1

[commit-bot: I haz the power, 2014-05-22 00:24:11]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-22 00:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 00:33:56]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Wez, 2014-05-22 00:36:56]

The CQ bit was checked by wez@chromium.org

[Wez, 2014-05-22 00:37:02]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2014-05-22 01:29:56]

PTAL

[Wez, 2014-05-22 16:37:57]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:40:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/292093002/40001

[commit-bot: I haz the power, 2014-05-22 17:48:35]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-22 17:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 17:56:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Sergey Ulanov, 2014-05-22 18:05:06]

https://codereview.chromium.org/292093002/diff/40001/remoting/protocol/sessio...
File remoting/protocol/session_config.cc (right):

https://codereview.chromium.org/292093002/diff/40001/remoting/protocol/sessio...
remoting/protocol/session_config.cc:219: ChannelConfig::CODEC_VP9));
I think you want to pass |codec| here instead of CODEC_VP9.

[Wez, 2014-05-22 18:17:54]

https://codereview.chromium.org/292093002/diff/40001/remoting/protocol/sessio...
File remoting/protocol/session_config.cc (right):

https://codereview.chromium.org/292093002/diff/40001/remoting/protocol/sessio...
remoting/protocol/session_config.cc:219: ChannelConfig::CODEC_VP9));
On 2014/05/22 18:05:06, Sergey Ulanov wrote:
> I think you want to pass |codec| here instead of CODEC_VP9.

D'oh! Thanks for the catch. :D

[Wez, 2014-05-22 18:26:31]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2014-05-22 18:29:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wez@chromium.org/292093002/40010

[commit-bot: I haz the power, 2014-05-22 21:31:23]

Change committed as 272324