ios/chrome/browser/ui/authentication/signin_interaction_controller.mm - Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects. (Closed)

Patch Set: rebase_fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm ('k') | ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

diff --git a/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm b/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

index 797f5683619bd5724b923652895aa450ada9a3e3..0f9905cac4bf2d2590dc7a6fef4653ae36c2ab11 100644

--- a/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

+++ b/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

@@ -115,8 +115,8 @@ using signin_ui::CompletionCallback;

[self showSigninViewControllerWithIdentity:nil identityAdded:NO];

} else {

identityInteractionManager_ =

- identityService->NewChromeIdentityInteractionManager(browserState_,

- self);

+ identityService->CreateChromeIdentityInteractionManager(browserState_,

+ self);

if (!identityInteractionManager_) {

// Abort sign-in if the ChromeIdentityInteractionManager returned is

// nil (this can happen when the iOS internal provider is not used).

@@ -162,7 +162,7 @@ using signin_ui::CompletionCallback;

identityInteractionManager_ =

ios::GetChromeBrowserProvider()

->GetChromeIdentityService()

- ->NewChromeIdentityInteractionManager(browserState_, self);

+ ->CreateChromeIdentityInteractionManager(browserState_, self);

__weak SigninInteractionController* weakSelf = self;

[identityInteractionManager_

reauthenticateUserWithID:base::SysUTF8ToNSString(idToReauthenticate)

@@ -181,7 +181,7 @@ using signin_ui::CompletionCallback;

identityInteractionManager_ =

ios::GetChromeBrowserProvider()

->GetChromeIdentityService()

- ->NewChromeIdentityInteractionManager(browserState_, self);

+ ->CreateChromeIdentityInteractionManager(browserState_, self);

__weak SigninInteractionController* weakSelf = self;

[identityInteractionManager_

addAccountWithCompletion:^(ChromeIdentity* identity, NSError* error) {