Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm

Issue 2920853006: Removes usage of signin APIs that return scoped_nsobjects. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
diff --git a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
index d68a3397bdcfeefb187ce72836dc081b86ce877e..e1d8a7160e075fa9576fd84a1b7138967aa40c0a 100644
--- a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
+++ b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
@@ -142,8 +142,8 @@ FakeChromeIdentityService::GetInstanceFromChromeProvider() {
ios::GetChromeBrowserProvider()->GetChromeIdentityService());
}
-base::scoped_nsobject<UINavigationController>
-FakeChromeIdentityService::NewAccountDetails(
+UINavigationController*
+FakeChromeIdentityService::CreateAccountDetailsController(
ChromeIdentity* identity,
id<ChromeIdentityBrowserOpener> browser_opener) {
base::scoped_nsobject<UIViewController> accountDetailsViewController(
@@ -154,13 +154,13 @@ FakeChromeIdentityService::NewAccountDetails(
return navigationController;
}
-base::scoped_nsobject<ChromeIdentityInteractionManager>
-FakeChromeIdentityService::NewChromeIdentityInteractionManager(
+ChromeIdentityInteractionManager*
+FakeChromeIdentityService::CreateChromeIdentityInteractionManager(
ios::ChromeBrowserState* browser_state,
id<ChromeIdentityInteractionManagerDelegate> delegate) const {
- base::scoped_nsobject<ChromeIdentityInteractionManager> manager(
- [[FakeChromeIdentityInteractionManager alloc] init]);
- manager.get().delegate = delegate;
+ ChromeIdentityInteractionManager* manager =
msarda 2017/06/08 23:21:07 Why is this change from scoped_nsobject to autorel
stkhapugin 2017/06/12 15:49:31 It is not strictly necessary, but it's equivalent,
+ [[[FakeChromeIdentityInteractionManager alloc] init] autorelease];
+ manager.delegate = delegate;
return manager;
}

Powered by Google App Engine
This is Rietveld 408576698