Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: chrome/browser/sync/sync_ui_util.h

Issue 2920853004: [sync] Display an error when sync settings aren't confirmed (Closed)
Patch Set: Reformat, remove browser_options change Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_ui_util.h
diff --git a/chrome/browser/sync/sync_ui_util.h b/chrome/browser/sync/sync_ui_util.h
index fcd841cb580867c231866a2e9f752e02543a4079..a416fa4cf6fc698c74a335d24477fd3cdfa5d1d6 100644
--- a/chrome/browser/sync/sync_ui_util.h
+++ b/chrome/browser/sync/sync_ui_util.h
@@ -29,11 +29,12 @@ enum MessageType {
// The action associated with the sync status.
enum ActionType {
- NO_ACTION, // No action to take.
- REAUTHENTICATE, // User needs to reauthenticate.
- SIGNOUT_AND_SIGNIN, // User needs to sign out and sign in.
- UPGRADE_CLIENT, // User needs to upgrade the client.
- ENTER_PASSPHRASE, // User needs to enter their passphrase.
+ NO_ACTION, // No action to take.
+ REAUTHENTICATE, // User needs to reauthenticate.
+ SIGNOUT_AND_SIGNIN, // User needs to sign out and sign in.
+ UPGRADE_CLIENT, // User needs to upgrade the client.
+ ENTER_PASSPHRASE, // User needs to enter their passphrase.
+ CONFIRM_SYNC_SETTINGS, // User needs to confirm sync settings.
};
enum StatusLabelStyle {
@@ -49,7 +50,8 @@ enum AvatarSyncErrorType {
SUPERVISED_USER_AUTH_ERROR, // Auth token error for supervised users.
AUTH_ERROR, // Authentication error.
UPGRADE_CLIENT_ERROR, // Out-of-date client error.
- PASSPHRASE_ERROR // Sync passphrase error.
+ PASSPHRASE_ERROR, // Sync passphrase error.
+ SETTINGS_UNCONFIRMED_ERROR, // Sync settings dialog not confirmed yet.
};
// TODO(akalin): audit the use of ProfileSyncService* service below,
@@ -78,9 +80,11 @@ MessageType GetStatusLabelsForNewTabPage(
#if !defined(OS_CHROMEOS)
// Gets the error message and button label for the sync errors that should be
// exposed to the user through the titlebar avatar button.
-AvatarSyncErrorType GetMessagesForAvatarSyncError(Profile* profile,
- int* content_string_id,
- int* button_string_id);
+AvatarSyncErrorType GetMessagesForAvatarSyncError(
+ Profile* profile,
+ const SigninManagerBase& signin,
+ int* content_string_id,
+ int* button_string_id);
#endif
MessageType GetStatus(Profile* profile,
« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_browser_proxy.js ('k') | chrome/browser/sync/sync_ui_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698