chrome/browser/ui/avatar_button_error_controller.cc - Issue 2920853004: [sync] Display an error when sync settings aren't confirmed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/avatar_button_error_controller.cc

Issue 2920853004: [sync] Display an error when sync settings aren't confirmed (Closed)

Patch Set: initialize button to nullptr Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/avatar_button_error_controller.cc

diff --git a/chrome/browser/ui/avatar_button_error_controller.cc b/chrome/browser/ui/avatar_button_error_controller.cc

index b4a0ff4562488cefe331beab416fbf29dc2e1999..59697f9122dda209e7011403215a5fedf434d60b 100644

--- a/chrome/browser/ui/avatar_button_error_controller.cc

+++ b/chrome/browser/ui/avatar_button_error_controller.cc

@@ -94,7 +94,8 @@ bool AvatarButtonErrorController::SyncErrorObserver::HasSyncError() {

sync_service->QueryDetailedSyncStatus(&status);

return sync_service->HasUnrecoverableError() ||

status.sync_protocol_error.action == syncer::UPGRADE_CLIENT ||

- (sync_error_controller && sync_error_controller->HasError());

+ (sync_error_controller && sync_error_controller->HasError()) ||

+ sync_service->IsSyncConfirmationNeeded();

}

return false;

}